BC - 4655 migration-of-federal-states #4385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
apps/server/src/modules/federal-state/service/federal-state.service.ts
Outdated
Show resolved
Hide resolved
| createdAt: new Date(2020, 1), | ||
| updatedAt: new Date(2020, 1), | ||
| }; | ||
| } |
There was a problem hiding this comment.
same as above (DoFactory) - should be unique, or?
apps/server/src/modules/federal-state/entity/federal-state.entity.ts
Outdated
Show resolved
Hide resolved
| @Module({ | ||
| imports: [FederalStateModule], | ||
| controllers: [FederalStateController], | ||
| providers: [FederalStateUC], |
There was a problem hiding this comment.
not sure this is ok...
…tes' into BC-4655-migration-of-federal-states
virgilchiriac
requested changes
Sep 21, 2023
apps/server/src/modules/federal-state/controller/dto/create-county.body.params.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/federal-state/controller/dto/federal-state.response.ts
Outdated
Show resolved
Hide resolved
| return federalStateResponse; | ||
| } | ||
|
|
||
| @Post() |
apps/server/src/modules/federal-state/controller/mapper/federal-state.mapper.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/federal-state/controller/mapper/federal-state.mapper.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/federal-state/repo/federal-state.repo.ts
Outdated
Show resolved
Hide resolved
| const createdFederalState = await this.federalStateService.create(federalStateCreate); | ||
| return createdFederalState; | ||
| } | ||
|
|
||
| // TODO: names could be an enum | ||
| async findFederalStateByName(name: string) { | ||
| const federalState = await this.federalStateService.findFederalStateByName(name); |
There was a problem hiding this comment.
no authorization here?
|
TODO: entity <-> county pagination - why is that necesary? findFederalStateByName - how was that called? was in feathers, but how is used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR will execute the migration from feathers to nestJs regarding FederalState.
Links to Tickets or other pull requests
BC-4655
Changes
FederalStates will be available through "/api/v3/federal-states". The old federal state feathers path is still used.
In a follow up ticket federalStates will no longer be available through the "/federalStates" route, but instead through "/api/v3/federal-states".
This has to be deleted in the follow up:
https://github.com/hpi-schul-cloud/schulcloud-server/tree/main/src/services/federalState
any reference to it from client, must be changed to the new v3 path
any reference to it from server, must somehow load nestjs service instead. Example https://github.com/hpi-schul-cloud/schulcloud-server/blob/main/src/services/sync/strategies/TSP/TSPBaseSyncer.js#L186
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.