Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1247 bbb waitingroom fix #4387

Merged
merged 8 commits into from
Sep 6, 2023
Merged

N21-1247 bbb waitingroom fix #4387

merged 8 commits into from
Sep 6, 2023

Conversation

mrikallab
Copy link
Contributor

@mrikallab mrikallab commented Sep 5, 2023

Description

This PR is a bug fix for validating the permission, if user is allowed to join videoconferences directly or should wait in the waitingroom. After Implementation of https://ticketsystem.dbildungscloud.de/browse/N21-941 this check was missing. The result was that the waitingroom was not working anymore for students and others.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1247

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@arnegns arnegns self-requested a review September 6, 2023 11:11
@mrikallab mrikallab changed the title N21-1247 check for waitingroom N21-1247 bbb waitingroom fix Sep 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mrikallab mrikallab merged commit ba5a64a into main Sep 6, 2023
42 of 43 checks passed
@mrikallab mrikallab deleted the N21-1247-bbb-waitingroom-fix branch September 6, 2023 14:09
uidp pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants