Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4964 Rename and update stuff in school module #4388

Merged
merged 40 commits into from
Sep 20, 2023

Conversation

dyedwiper
Copy link
Contributor

@dyedwiper dyedwiper commented Sep 5, 2023

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-4964

hpi-schul-cloud/nuxt-client#2811

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link
Contributor

@SevenWaysDP SevenWaysDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich bin mir aber nicht sicher ob man jetzt besser versteht, das (Rule, repo, etc.) hat nicht viel mit school-migration zutun

@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dyedwiper dyedwiper merged commit d0aac38 into main Sep 20, 2023
42 of 43 checks passed
@dyedwiper dyedwiper deleted the bc-4964-rename-school-stuff-v2 branch September 20, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants