BC-4770 update nestjs to version 10 #4391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-10' into bc-4770-update-nestjs-to-version-10
CeEv
requested changes
Sep 11, 2023
apps/server/src/modules/files-storage-client/mapper/error.mapper.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/files-storage/uc/files-storage-upload.uc.spec.ts
Outdated
Show resolved
Hide resolved
bergatco
approved these changes
Sep 12, 2023
CeEv
previously requested changes
Sep 12, 2023
| let consoleWriter: ConsoleWriterService; | ||
| let logMock: jest.SpyInstance; | ||
| beforeEach(async () => { | ||
| bootstrap = new TestBootstrapConsole({ |
There was a problem hiding this comment.
Can you please split the beforeEach and beforeAll / afterEach and AfterAll? The bootstrap must not make done again.
There was a problem hiding this comment.
I don't understand why, but it runs into timeout when I set to beforeAll
thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
apps/server/src/console/api-test/database-management.console.api.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/files-storage/uc/files-storage-upload.uc.spec.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
virgilchiriac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
BC-4770
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.