Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5065 - Deployments restart at config change #4393

Closed
wants to merge 2 commits into from
Closed

Conversation

mamutmk5
Copy link
Member

@mamutmk5 mamutmk5 commented Sep 7, 2023

Description

The kubernetes deployments will be update if the config change so that the pods for the k8s deployments where updated.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5065
hpi-schul-cloud/dof_app_deploy#632

Changes

Add a label, cfgVersion, to the metadata for the deployment and pod template in the deployment, who is set to the dof_app_deploy version ( image tag )

Datasecurity

Deployment

Deployment restarts with each update in the same branch at dof_app_deploy

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mamutmk5
Copy link
Member Author

this poc woud be restart the deployments every time even there is no restart needed, so discard

@mamutmk5 mamutmk5 closed this Sep 11, 2023
@mamutmk5 mamutmk5 deleted the BC-5065 branch September 11, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant