Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4375 - show submission status #4395

Closed
wants to merge 2 commits into from

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Sep 8, 2023

Description

Show submissions of the students for the teacher (inside Card with Submission-Element).

Links to Tickets or other pull requests

BC-4375
hpi-schul-cloud/nuxt-client#2794

Changes

  • added usersList to getRoomBoard response with id, firstName and lastName for every assigned user (students array of course/room)

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher added the WIP This feature branch is in progress, do not merge into master. label Sep 8, 2023
@MartinSchuhmacher MartinSchuhmacher self-assigned this Sep 8, 2023
@@ -74,22 +75,31 @@ describe('rooms controller', () => {
describe('when simple room is fetched', () => {
const setup = () => {
const currentUser = { userId: 'userId' } as ICurrentUser;
// const roles = roleFactory.buildList(1, { permissions: [] });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@virgilchiriac
Copy link
Contributor

PR dismissed - another one will be opened

@virgilchiriac virgilchiriac deleted the BC-4375-show-submission-status branch September 15, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP This feature branch is in progress, do not merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants