Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5101 - go back to docker/build-push-action@v4 #4397

Merged
merged 2 commits into from
Sep 11, 2023
Merged

BC-5101 - go back to docker/build-push-action@v4 #4397

merged 2 commits into from
Sep 11, 2023

Conversation

mamutmk5
Copy link
Member

@mamutmk5 mamutmk5 commented Sep 11, 2023

Description

Go back to docker/build-push-action@v4 and solfe the issue with the malformed docker config

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-5101
hpi-schul-cloud/schulcloud-client#3300
hpi-schul-cloud/nuxt-client#2796
hpi-schul-cloud/superhero-dashboard#230
hpi-schul-cloud/schulcloud-calendar#142
hpi-schul-cloud/antivirus_check_service#42
hpi-schul-cloud/version-aggregator#11
hpi-schul-cloud/h5p-staticfiles-server#4

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mamutmk5 mamutmk5 merged commit b5e4628 into main Sep 11, 2023
43 checks passed
@mamutmk5 mamutmk5 deleted the BC-5101 branch September 11, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants