Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-4975 - Only resize image if original width is bigger than target width #4398

Merged
merged 3 commits into from
Sep 11, 2023
Merged

BC-4975 - Only resize image if original width is bigger than target width #4398

merged 3 commits into from
Sep 11, 2023

Conversation

bischofmax
Copy link
Contributor

@bischofmax bischofmax commented Sep 11, 2023 •
edited
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@bischofmax bischofmax self-assigned this Sep 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@bischofmax bischofmax merged commit 6fb3f65 into main Sep 11, 2023
43 checks passed
@bischofmax bischofmax deleted the BC-4975-display-small-images branch September 11, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergatco bergatco bergatco approved these changes

@SevenWaysDP SevenWaysDP SevenWaysDP approved these changes

Assignees

@bischofmax bischofmax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bischofmax @SevenWaysDP @bergatco