-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-4208 - BC-5116 - fix switchSchool by calling teamsRepo directly #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CeEv
approved these changes
Sep 12, 2023
fixup nest code .. orm lost track of the cloned teams which it should save afterwards, might work in some cases but not with embedded entites messy javascript world it is original error message: Trying to persist not discovered entity of type object.
bn-pass
approved these changes
Sep 12, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs 100.0% Coverage The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
virgilchiriac
changed the title
BC-4208 fix switchSchool by calling teamsRepo directly
BC-4208 - BC-5116 - fix switchSchool by calling teamsRepo directly
Sep 21, 2023
virgilchiriac
pushed a commit
that referenced
this pull request
Sep 21, 2023
* added logs * use nest code instead of legacy code fixup nest code .. orm lost track of the cloned teams which it should save afterwards, might work in some cases but not with embedded entities messy javascript world it is original error message: Trying to persist not discovered entity of type object. --------- Co-authored-by: Cedric Evers <12080057+CeEv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
BC-4208
BC-5116
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.