Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-4208 - BC-5116 - fix switchSchool by calling teamsRepo directly #4402

Merged
merged 10 commits into from
Sep 13, 2023

Conversation

Loki-Afro
Copy link
Member

@Loki-Afro Loki-Afro commented Sep 11, 2023

Description

Links to Tickets or other pull requests

BC-4208
BC-5116

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

CeEv and others added 3 commits September 12, 2023 09:09
fixup nest code .. orm lost track of the cloned teams which it should
save afterwards, might work in some cases but not with embedded entites

messy javascript world it is
original error message: Trying to persist not discovered entity of type object.
@Loki-Afro Loki-Afro requested a review from Metauriel September 12, 2023 16:41
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@Loki-Afro Loki-Afro merged commit 971b68e into main Sep 13, 2023
42 of 43 checks passed
@Loki-Afro Loki-Afro deleted the bc-4208-calling-teams-repo-directly branch September 13, 2023 13:33
@virgilchiriac virgilchiriac changed the title BC-4208 fix switchSchool by calling teamsRepo directly BC-4208 - BC-5116 - fix switchSchool by calling teamsRepo directly Sep 21, 2023
virgilchiriac pushed a commit that referenced this pull request Sep 21, 2023
* added logs
* use nest code instead of legacy code

fixup nest code .. orm lost track of the cloned teams which it should
save afterwards, might work in some cases but not with embedded entities

messy javascript world it is
original error message: Trying to persist not discovered entity of type object.

---------

Co-authored-by: Cedric Evers <12080057+CeEv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants