Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5611 - add new create-task-endpoint #4499

Closed
wants to merge 1 commit into from

Conversation

wolfganggreschus
Copy link
Contributor

@wolfganggreschus wolfganggreschus commented Oct 25, 2023

Description

This pr is part of the migration of homework from Feathers to NestJS. There is an existing Task module in Nest where the logic for creating a new task (homework) should be implemented. The old create-homework procedure should be removed.
A part of this ticket should involve the frontend using the new endpoint.

Links to Tickets or other pull requests

BC-5611
hpi-schul-cloud/schulcloud-client#3339

Changes

Endpoint "POST /homework/{id}" should be replaced by "POST /api/v3/task/{id}"

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@wolfganggreschus wolfganggreschus changed the title BC-5611 BC-5611 - add new create-task-endpoint Oct 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant