Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2287 Fix partial course sync start for admins #5343

Merged
merged 6 commits into from
Nov 15, 2024
Merged

N21-2287 Fix partial course sync start for admins #5343

merged 6 commits into from
Nov 15, 2024

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 14, 2024 •
edited by GordonNicholasCap
Loading

Description

Links to Tickets or other pull requests

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

GordonNicholasCap
GordonNicholasCap requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@GordonNicholasCap GordonNicholasCap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, small changes needed

apps/server/src/modules/group/domain/group.spec.ts Outdated Show resolved Hide resolved
apps/server/src/modules/learnroom/domain/do/course.ts Outdated Show resolved Hide resolved
apps/server/src/modules/role/service/dto/role.dto.ts Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 9c8ba28 into main Nov 15, 2024
76 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2287-fix-partial-sync branch November 15, 2024 12:31
hoeppner-dataport pushed a commit that referenced this pull request Nov 18, 2024
@MarvinOehlerkingCap @hoeppner-dataport
N21-2287 Fix partial course sync start for admins (#5343)
4ad1a0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonNicholasCap GordonNicholasCap GordonNicholasCap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @GordonNicholasCap