Display unsupported messages correctly #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure unsupported messages are displayed even if the chat is already open when they arrive.
|
Apparently, there are no tests for the patched class |
LinqLover
added a commit
to LinqLover/TelegramBot
that referenced
this pull request
Oct 8, 2020
LinqLover
added a commit
to LinqLover/TelegramBot
that referenced
this pull request
Oct 12, 2020
- Add GitHub Action workflow (`.github/workflows/main.yml`) to run tests using smalltalkCI (`.smalltalk.ston`) - Make integration tests CI-ready by providing: * secret variables for bot and client (they also have been defined in the [repository settings](https://github.com/LinqLover/TelegramBot/settings/secrets)) * a test database for TelegramClient (see `assets/tests/tdlib.zip.gpg`) that works out of the box without using a new authentication code. It is encrypted using another secret variable. * revising the `TelegramBotIntegrationTest` running logic to make it more robust and fail-safe - Fix baseline and specify missing dependencies * Create an extra package (`TelegramBot-Support-ShoutAttribute`) for extensions depending on the not-yet-released `ShoutAttribute` changeset (4680c53) * Add `BaselineOfTelegramBot >> #installPreviewDependencies` to install other not-yet-released proposals for the Squeak Trunk (works around Metacello/metacello#528 and Metacello/metacello#530) * Depend on [fork](https://github.com/LinqLover/TelegramClient) of [TelegramClient](https://github.com/hpi-swa-teaching/TelegramClient) until hpi-swa-teaching/TelegramClient#311, hpi-swa-teaching/TelegramClient#312 have been merged (528ae9a) * Add missing and remove superfluous extension methods - API: Revise offset computation for getUpdates method (89c79a0) - Fix `TelegramBotRequest >> #testSendAudio` (305755e) - Add badges to `README.md` (7621356)
Mrnikbobjeff
approved these changes
Oct 20, 2020
|
Great, thank you for reviewing all these PRs! |
LinqLover
added a commit
to LinqLover/TelegramBot
that referenced
this pull request
Mar 22, 2021
When sending a message from the bot failed because the recipient has blocked the bot, no longer get stuck in the central update cycle by raising one TelegramBotError(403) after the other, but instead raise a dedicated TelegramBotFailure and proceed with the next update. Subclasses can refine the handling of blocked messages by overriding the hook #messageBlocked:withError:. Also introduced a new fancy Abort exception. 🤓 Fixes #17. Tests are included as well. Also reverts baseline workaround solution from 528ae9a (hpi-swa-teaching/TelegramClient#311 and hpi-swa-teaching/TelegramClient#312 are merged now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure unsupported messages are displayed even if the chat is already open when they arrive.
Fixes #306.