Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference detection does not look "behind" added objects #135

Closed
j4yk opened this issue Oct 1, 2017 · 2 comments
Closed

Difference detection does not look "behind" added objects #135

j4yk opened this issue Oct 1, 2017 · 2 comments
Assignees
@j4yk
Labels
bug Squot
Milestone
release 0.8.0

Comments

@j4yk
Copy link
Collaborator

j4yk commented Oct 1, 2017

If object A refers to object B before a change, but an indirection via object C is subsequently introduced (so A does not refer to B any longer) and B is also changed, the changes in B will not be detected currently. To fix this, the SquotDiffBuilder must follow the references of added objects and continue diffing when it encounters existing objects.
j4yk added a commit that referenced this issue Sep 21, 2019
@j4yk
Compare objects behind added objects
7ac941d 
Changes to objects only referenced from those added objects
previously went unnoticed because the SquotDiffBuilder never
visited them.

Ref #135
@j4yk
Copy link
Collaborator Author

j4yk commented Sep 24, 2019

See also 9411763

@j4yk j4yk added this to the release 0.8.0 milestone Sep 26, 2019
@j4yk j4yk self-assigned this Dec 8, 2019
j4yk added a commit to j4yk/Squot that referenced this issue May 17, 2020
@j4yk
Compare objects behind added objects
02630f7 
Changes to objects only referenced from those added objects
previously went unnoticed because the SquotDiffBuilder never
visited them.

Ref hpi-swa#135

(cherry-picked from commit 7ac941d)
@j4yk
Copy link
Collaborator Author

j4yk commented Jun 6, 2020

Already resolved on the develop branch. See the two commits already referenced above: 7ac941d, 9411763

@j4yk j4yk closed this as completed Jun 6, 2020
@j4yk j4yk mentioned this issue Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j4yk j4yk

Labels
bug Squot
Projects
None yet
Milestone
release 0.8.0
Development

No branches or pull requests
1 participant
@j4yk