Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write .properties file for tonel repositories #282

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

j4yk
Copy link
Collaborator

@j4yk j4yk commented Sep 3, 2020

When going back to #filetree, write that into the properties.
Closes #277

When going back to #filetree, write that into the properties.
Closes #277
@j4yk j4yk requested a review from marceltaeumel September 3, 2020 20:51
@j4yk j4yk added the workaround-for-third-parties Issues or fixes added to work around a problem in other software not maintained here. label Sep 4, 2020
@j4yk j4yk requested a review from tom95 September 5, 2020 15:13
@tom95
Copy link
Collaborator

tom95 commented Sep 19, 2020

Tried it and it works great! One concern: the current implementation will overwrite other fields set in the .properties file. I checked a bunch of pharo repos and found none that used other fields besides #format, so we could also defer this extra step.

@j4yk
Copy link
Collaborator Author

j4yk commented Sep 20, 2020

I think I can live with that for the time being. ;-)

@j4yk j4yk merged commit 731a3ce into develop Sep 20, 2020
@j4yk j4yk deleted the feature/write-properties-for-iceberg-tonel branch December 2, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workaround-for-third-parties Issues or fixes added to work around a problem in other software not maintained here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.properties is missing in Tonel-based repository
2 participants