Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: fixes for dialog text fields (save version dialog + feedback dialog) #380

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

ui: fixes for dialog text fields (save version dialog + feedback dialog) #380

wants to merge 6 commits into from

Commits on Jun 17, 2022

  1. ui: fixes for dialog text fields (save version dialog + feedback dialog) 

    * disable formatting in text fields (>= Squeak 6.0)
* save version dialog: implement setTextSelector (#message:) correctly to let the view know that the save was successful (will remove the orange triangle)
* save version dialog: fix cancel to actually reset the text (#okToRevertChanges:) (>= Squeak 6.0)
* feedback dialog: instead of hacking #editText:, update all dialog texts prior to submitting via #acceptChanges. This way, undo/redo is working as normally and the edit indication semantics of the toolbuilder are maintained.
    @LinqLover
    LinqLover committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    b1f6e31 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Merge branch 'develop' of fork into fix/dialog-text-fields

    @LinqLover
    LinqLover committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ca4d612 View commit details
    Browse the repository at this point in the history

  2. Once again, fix Squot merge errors

    @LinqLover
    LinqLover committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    09e2415 View commit details
    Browse the repository at this point in the history

  3. Once again, fix Squot merge errors

    @LinqLover
    LinqLover committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1946069 View commit details
    Browse the repository at this point in the history

  4. Fix: drafted commit message not updated after pressing cmd + l and re… 

    …-opening the version saver
    @LinqLover
    LinqLover committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    45eedac View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Revert "Fix: drafted commit message not updated after pressing cmd + … 

    …l and re-opening the version saver"

This reverts commit 45eedac.

Turned out that there is little sense in restoring the placeholder text permanently. See: hpi-swa#380 (comment)
    @LinqLover
    LinqLover committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    bc66078 View commit details
    Browse the repository at this point in the history