Fix a crash in primitiveBeCursor

Closes #151
hpi-swa · Nov 1, 2021 · 8cfb5df · 8cfb5df
1 parent 115bc7d
commit 8cfb5df
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/io/SqueakDisplay.java b/src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/io/SqueakDisplay.java
@@ -321,7 +321,9 @@ public void setCursor(final int[] cursorWords, final int[] mask, final int width
                     }
                 }
             }
-            cursor = TOOLKIT.createCustomCursor(bufferedImage, new Point(offsetX, offsetY), "TruffleSqueak Cursor");
+            // Ensure hotspot is within cursor bounds.
+            final Point hotSpot = new Point(Math.min(Math.max(offsetX, 1), width - 1), Math.min(Math.max(offsetY, 1), height - 1));
+            cursor = TOOLKIT.createCustomCursor(bufferedImage, hotSpot, "TruffleSqueak Cursor");
         }
         frame.setCursor(cursor);
     }

diff --git a/...pi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/primitives/impl/IOPrimitives.java b/...pi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/primitives/impl/IOPrimitives.java
@@ -217,12 +217,16 @@ protected final PointersObject doCursor(final PointersObject receiver, final Poi
                 final PointersObject offset = receiver.getFormOffset(cursorReadNode);
                 final int offsetX = Math.abs(offsetReadNode.executeInt(offset, POINT.X));
                 final int offsetY = Math.abs(offsetReadNode.executeInt(offset, POINT.Y));
+                final int[] mask;
+                final int realDepth;
                 if (depthProfile.profile(depth == 1)) {
-                    final int[] mask = cursorReadNode.executeNative(maskObject, FORM.BITS).getIntStorage();
-                    image.getDisplay().setCursor(words, mask, width, height, 2, offsetX, offsetY);
+                    mask = cursorReadNode.executeNative(maskObject, FORM.BITS).getIntStorage();
+                    realDepth = 2;
                 } else {
-                    image.getDisplay().setCursor(words, null, width, height, depth, offsetX, offsetY);
+                    mask = null;
+                    realDepth = depth;
                 }
+                image.getDisplay().setCursor(words, mask, width, height, realDepth, offsetX, offsetY);
             }
             return receiver;
         }