Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion of error handling #44

Closed
elfring opened this issue Dec 8, 2020 · 3 comments
Closed

Completion of error handling #44

elfring opened this issue Dec 8, 2020 · 3 comments

Comments

@elfring
Copy link

elfring commented Dec 8, 2020

Would you like to add more error handling for return values from a function like “fwrite”?

@hpjansson
Copy link
Owner

Yes, that would be a good idea. I think that on failure, it should just goto out;. This also needs to happen in run_gif().

Tangentially, I'm not too happy with the two main loops. Long term I'd like to refactor this code and move it into its own unit with a player-like API (e.g. player.c) that could be called from chafa.c. It could use GError to report errors properly.

hpjansson added a commit that referenced this issue Aug 6, 2021
@elfring
Copy link
Author

elfring commented Aug 8, 2021

Thanks for your small source code adjustment.

@hpjansson
Copy link
Owner

Anytime 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants