Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify auto check for updates #262

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Conversation

hql287
Copy link
Owner

@hql287 hql287 commented Mar 9, 2018

Description

This PR simplified the way Manta handle checking for updates by removing unnecessary settings and automatically check for update on startup.

Related Issue

Issue #261

Motivation and Context

  • The user won't need to remember whether they should check for update or not (unless they want to) as this would be handled automatically by Manta.
  • Unnecessary options such as check for updates frequency will be safely removed from the app, UI will be simplified.

How Has This Been Tested?

  • On startup, Manta did run the checkForUpdate function silently (Using a simple console.log())
  • If there's new update, showed a dialogue box
  • If there's no update, did nothing.
  • If the user check for update explicitly, always show dialogue box.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have included a migration scheme (If type of change is breaking change)

@hql287 hql287 added this to the Build 06 - v1.1.4 milestone Mar 9, 2018
@hql287 hql287 self-assigned this Mar 9, 2018
@hql287 hql287 merged commit 38e38a7 into dev Mar 9, 2018
@hql287 hql287 mentioned this pull request Mar 9, 2018
5 tasks
@hql287 hql287 deleted the simplify-auto-check-for-updates branch March 10, 2018 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant