Skip to content

Commit

Permalink
Fix dangling reference to bazel.fish.
Browse files Browse the repository at this point in the history
This was changed in bazelbuild@20febac, but we forgot to update this reference. We only noticed this when trying to build the next release, because in the normal postsubmit the installer isn't built.

This CL also adds the release artifacts to the CI config so this cannot happen again.

PiperOrigin-RevId: 343119629
  • Loading branch information
philwo authored and copybara-github committed Nov 18, 2020
1 parent ddcf5f7 commit 37a429a
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .bazelci/postsubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ tasks:
- "--test_env=TEST_INSTALL_BASE=$HOME/bazeltest/install_base"
- "--test_env=TEST_REPOSITORY_HOME=$OUTPUT_BASE/external"
build_targets:
- "//:bazel-distfile.zip"
- "//scripts/packages/debian:bazel-debian.deb"
- "//scripts/packages:with-jdk/install.sh"
- "//src:bazel"
- "//src:bazel_jdk_minimal"
- "//src:test_repos"
Expand Down
3 changes: 3 additions & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ tasks:
- "--test_env=TEST_INSTALL_BASE=$HOME/bazeltest/install_base"
- "--test_env=TEST_REPOSITORY_HOME=$OUTPUT_BASE/external"
build_targets:
- "//:bazel-distfile.zip"
- "//scripts/packages/debian:bazel-debian.deb"
- "//scripts/packages:with-jdk/install.sh"
- "//src:bazel"
- "//src:bazel_jdk_minimal"
- "//src:test_repos"
Expand Down
2 changes: 1 addition & 1 deletion scripts/packages/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ genrule(
":%s/bazel-real" % kind,
":%s/bazel" % kind,
"//scripts:bash_completion",
"//scripts/fish:completions/bazel.fish",
"//scripts:bazel.fish",
"//scripts/zsh_completion:_bazel",
],
launcher = ":launcher_bin.sh",
Expand Down

0 comments on commit 37a429a

Please sign in to comment.