-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from master #169
Merged
Merged
Merge from master #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> (<class 'custom_components.tasmota_irhvac.climate.TasmotaIrhvac'>) is > using self.async_update_ha_state(), without enabling force_update. > Instead it should use self.async_write_ha_state()
Fix #108 use `async_write_ha_state()`
…eate_task()` This is a fix for an error affected by Python 3.11 introduced in HA 2023.6.0.
Certain devices may update their own state at certain times, breaking the synchronization between the state maintained by Home Assistant and the state of the device. This new service option allows you to keep Home Assistant and your device state synchronized.
Added config variables for `ignore_off_temp` and `ignore_off_mode`
Fix for #117 Ignore off temp
Add missing option "high" in UI service call for set_swingv
spelling
Fixed spelling in services.yaml
async_track_state_change is deprecated and will be removed in Home Assistant 2025.5. async_track_state_change_event should be used instead. This fix is designed to maintain backward compatibility.
1. Supports HA 2024.6.0 2. Added the ability to subscribe to both "tele" and "stat" messages state_topic: "tele/your_tasmota_device/RESULT" state_topic_2: "stat/your_tasmota_device/RESULT"
Replace self.fan_mode by self._attr_fan_mode, because the latter is used everywhere else.
self._attr_fan_modes already contains values rewritten to FAN_HIGH and HVAC_FAN_MAX. `if fan_mode not in self._attr_fan_modes`, it's impossible to fail the `fan_mode != FAN_HIGH and fan_mode != HVAC_FAN_MAX` check. Also fix a typo: "swing mode" -> "fan mode".
HVAC_FAN_MAX_HIGH and HVAC_FAN_AUTO_MAX are filtered out from self._attr_fan_modes in __init__(). All the further checks for HVAC_FAN_MAX_HIGH and HVAC_FAN_AUTO_MAX will always fail, making the ELECTRA_AC workaround a no-op. Fix it by storing the workaround status in self._quirk_fan_max_high. Fixes: de5a190 ("Aggressive use of _attr_* properties, cleanup and normalization")
Home Assistant has standard high/low fan modes that are localized and displayed in the UI in a pretty way. Tasmota IRHVAC has min, low, middle, high and max, along with a few other modes. Min and max are displayed in Home Assistant as is and not localized. While nothing can be done on the integration side for air conditioners that use 5 levels of the fan, some air conditioners have 3 levels, but use min/medium/max instead of low/medium/high. For such ACs, convert min->low and max->high to display pretty localized values in the UI.
Fix fan modes
Revert "Fix fan modes"
…x-fan-modes Fix fan modes
Remove the previos fix for fan modes. The changes were not working as expexted and lead to confusion when altering the displayed properties in the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.