Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cargo): prevent crate filename collision #1395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThomasFrans
Copy link
Contributor

cargo has a bug that prevents correct handling of similarly named crates in the same package. Rename the internal library crate to prevent error messages. rust-lang/cargo#10368

Describe your changes

Rename the library crate in the ncspot package. Instead of the implicit name ncspot, give it a name in the cargo manifest.

Checklist before requesting a review

  • Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
  • Changelog was updated with relevant user-facing changes (eg. not dependency updates,
    not performance improvements, etc.)

@ThomasFrans
Copy link
Contributor Author

This solves a minor issue when generating documentation for the binary crate. Without this fix, it throws a warning like in the following image.

image

`cargo` has a bug that prevents correct handling of similarly named
crates in the same package. Rename the internal library crate to prevent
error messages. rust-lang/cargo#10368
@ThomasFrans ThomasFrans force-pushed the fix-cargo-filename-collision branch from fbe866e to fd8ac9f Compare May 7, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant