Fields and wide menu #1

[gegoune]

Hey, I have noticed that if I omit a field from custom formatted window it gets way wider than it needs to be. For example, this is default with formatting = {} (I am using cmdline plugin here, but it's the same for main cmp's window):

So far so good. Let's add some kind icons (from wiki):

  formatting = {
    fields = { cmp.ItemField.Abbr, cmp.ItemField.Kind },
    format = function(_, vim_item)
      vim_item.kind = cmp_kinds[vim_item.kind] or ' '
      return vim_item
    end,
  },

and we get:

Still OK. Let's replace kind with source name coming from entry bundled with kind:

  formatting = {
    fields = { cmp.ItemField.Abbr, cmp.ItemField.Menu },
    format = function(entry, vim_item)
      vim_item.menu = ' '
        .. (({ nvim_lsp = 'lsp', cmp_git = 'git' })[entry.source.name] or entry.source.name)
        .. ': '
        .. vim_item.kind

      return vim_item
    end,
  },

Not so good, window expands further than it really needs to. I was thinking that menu is breaking it somehow, but let add icons back in:

  formatting = {
    fields = { cmp.ItemField.Kind, cmp.ItemField.Abbr, cmp.ItemField.Menu },
    format = function(entry, vim_item)
      vim_item.menu = ' '
        .. (({ nvim_lsp = 'lsp', cmp_git = 'git' })[entry.source.name] or entry.source.name)
        .. ': '
        .. vim_item.kind

      vim_item.kind = cmp_kinds[vim_item.kind] or ' '

      return vim_item
    end,
  },

and everything is back to how it should be:

Why is abbr+kind displayed like that? @hrsh7th is that a bug or am I doing something utterly bananas here?
Thanks!

[GlekoMa]

This is a feature. Change items order will change the display order. See #337
And this is the document (cmp.txt) description:

Update：
I'm sorry I misunderstood the description. 😥
@fitrh is right. kind and abbr display by default unless manually set.
Perhaps it would be more intuitive to leave it all to the field (not only specify the order but also behavior)?
I found an issue (#1154 (comment)) similar.

[fitrh]

  formatting = {
    fields = { cmp.ItemField.Abbr, cmp.ItemField.Menu },
    format = function(entry, vim_item)
      vim_item.menu = ' '
        .. (({ nvim_lsp = 'lsp', cmp_git = 'git' })[entry.source.name] or entry.source.name)
        .. ': '
        .. vim_item.kind

      return vim_item
    end,
  },

For this code to work as expected, the vim_item.kind need to set to nil

  formatting = {
    fields = { cmp.ItemField.Abbr, cmp.ItemField.Menu },
    format = function(entry, vim_item)
      vim_item.menu = ' '
        .. (({ nvim_lsp = 'lsp', cmp_git = 'git' })[entry.source.name] or entry.source.name)
        .. ': '
        .. vim_item.kind
+     vim_item.kind = nil
      return vim_item
    end,
  },

[gegoune]

I have no longer need to do this so won't test it, but it indeed looks like a solution. Thank you!