Skip to content

Commit

Permalink
Address some feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
hrydgard committed Jul 12, 2020
1 parent 873c11d commit 7dcd708
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Core/Core.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
#include "Windows/InputDevice.h"
#endif


// Time until we stop considering the core active without user input.
// Should this be configurable? 2 hours currently.
static const double ACTIVITY_IDLE_TIMEOUT = 2.0 * 3600.0;
Expand Down Expand Up @@ -385,6 +384,7 @@ const char *ExceptionTypeAsString(ExceptionType type) {
switch (type) {
case ExceptionType::MEMORY: return "Invalid Memory Access";
case ExceptionType::BREAK: return "Break";
case ExceptionType::BAD_EXEC_ADDR: return "Bad Execution Address";
default: return "N/A";
}
}
Expand Down
1 change: 1 addition & 0 deletions Core/Core.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ enum class ExceptionType {
NONE,
MEMORY,
BREAK,
BAD_EXEC_ADDR,
};

struct ExceptionInfo {
Expand Down
1 change: 1 addition & 0 deletions Core/MIPS/MIPSInt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ namespace MIPSInt

void Int_Break(MIPSOpcode op)
{
Reporting::ReportMessage("BREAK instruction hit");
Core_Break();
PC += 4;
}
Expand Down
2 changes: 1 addition & 1 deletion Core/System.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ bool coreCollectDebugStatsForced = false;

// This can be read and written from ANYWHERE.
volatile CoreState coreState = CORE_STEPPING;
// Note: intentionally not used for CORE_NEXTFRAME. << TODO: This comment is a lie, it is used!
// If true, core state has been changed, but JIT has probably not noticed yet.
volatile bool coreStatePending = false;

static volatile CPUThreadState cpuThreadState = CPU_THREAD_NOT_RUNNING;
Expand Down

0 comments on commit 7dcd708

Please sign in to comment.