Use remove_if correctly.

hrydgard · Apr 5, 2024 · ad7da71 · ad7da71
1 parent 5bead8d
commit ad7da71
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/Core/Config.cpp b/Core/Config.cpp
@@ -1516,10 +1516,12 @@ void Config::RemoveRecent(const std::string &file) {
 	std::lock_guard<std::mutex> guard(private_->recentIsosLock);
 
 	const auto &filename = File::ResolvePath(file);
-	std::remove_if(recentIsos.begin(), recentIsos.end(), [filename](const auto &str) {
+	auto iter = std::remove_if(recentIsos.begin(), recentIsos.end(), [filename](const auto &str) {
 		const auto &recent = File::ResolvePath(str);
 		return filename == recent;
 	});
+	// remove_if is weird.
+	recentIsos.erase(iter, recentIsos.end());
 }
 
 void Config::CleanRecent() {