Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linux] [Vulkan] Toggle fullscreen doesn't update display properly #11974

Closed
vnctdj opened this issue Apr 15, 2019 · 7 comments
Closed

[Linux] [Vulkan] Toggle fullscreen doesn't update display properly #11974

vnctdj opened this issue Apr 15, 2019 · 7 comments
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan
Milestone

Comments

@vnctdj
Copy link
Contributor

vnctdj commented Apr 15, 2019

Display does update properly when resizing manually though.

I've recorded a video in order to understand the issue easily:
https://www.youtube.com/watch?v=Eh1DEtKflbQ

I don't know if it's relevant, but this error appears in the log when toggling off:
E: buffer.cpp:157: FlushSocket failed

OS: Debian GNU/Linux buster/sid x86_64
Kernel: 4.19.0-4-amd64
WM: i3
CPU: Intel i7-6700HQ (8) @ 3.500GHz
GPU: NVIDIA GeForce GTX 960M
PPSSPP: v1.8.0-102-g057e720b2

@unknownbrackets unknownbrackets added SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan labels Apr 16, 2019
@unknownbrackets
Copy link
Collaborator

Hm, something must be wrong with the timing of the resize event. I think we change the flags to tell the window to be fullscreen or not, and maybe we don't react to the event when it actually happens and tell Vulkan to resize?

Maybe this is causing issues for GL on some platforms too.

-[Unknown]

@orbea
Copy link
Contributor

orbea commented Apr 25, 2019

Probably at least partially a duplicate of issue #11625.

Edit: Just to be clear I can't reproduce this issue on the master with GL or vulkan, but I am using radv and not nvidia.

@hrydgard hrydgard modified the milestones: v1.9.0, v1.10.0 Aug 23, 2019
@hrydgard hrydgard modified the milestones: v1.10.0, v1.11.0 Apr 28, 2020
@vnctdj
Copy link
Contributor Author

vnctdj commented Jun 23, 2020

I think the relevant piece of log is:
W: VulkanRenderManager.cpp:1036: VK_ERROR_OUT_OF_DATE_KHR returned - not presenting
(PPSSPP v1.9.3-1058-gaf7995c55)

Also I found that toggling fullscreen while not rendering the game's frames circumvents the issue:
https://www.youtube.com/watch?v=H1rHD-MYH6Y

@hrydgard
Copy link
Owner

OK so now the menu seems to behave correctly but not the game itself? Interesting, will try to repro.

@hrydgard
Copy link
Owner

Yeah, toggling fullscreen using a shortcut key is still broken. I'll dig into this.

hrydgard added a commit that referenced this issue Jun 23, 2020
Partly clean up SDL resize code, should help #11974
@hrydgard
Copy link
Owner

Try again on master.

On Intel there's an issue where alt-tabbing away during fullscreen will crash. This appears to be a driver bug.

@vnctdj
Copy link
Contributor Author

vnctdj commented Jun 24, 2020

That's fixed! Thanks a lot Henrik!

Edit: I can't change the milestone.

@vnctdj vnctdj closed this as completed Jun 24, 2020
vnctdj added a commit to vnctdj/ppsspp that referenced this issue Jun 25, 2020
@hrydgard hrydgard modified the milestones: v1.11.0, v1.10.0 Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports. Vulkan
Projects
None yet
Development

No branches or pull requests

4 participants