-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persona 3 Portable Lines in Tartarus transformation scene #12558
Comments
Could you try exporting a GE frame dump? These help a lot. See here for instructions - it's not hard and works on Android too: You can zip that and then drag and drop it into a reply here. -[Unknown] |
DUMP.zip |
No it's not a correct scene, like this: |
This is an antialias issue. It actually sets the texture to itself, but the UVs are garbage. There are actually two incorrect sets of lines there. It should correctly look like this: Software rendering isn't terrible, although you'll notice more aliasing on the rightmost object: It uses GE_PRIM_LINES but skinning is not enabled, so our crummy heuristics in hardware don't skip it. If we did skip, it'd look like this (taken from the GE debugger before presenting, that's why it's darker): A lot more aliasing in the same object, but certainly better than the lines. We could probably do what software does if we made a copy (like we already do for special blending modes.) -[Unknown] |
And this one too: |
We could always add a compat setting to kill off all AA lines... What game was it that required us to not kill AA lines? I think we might want to either do the above or adjust our indeed pretty crummy heuristics. Echochrome, or something? |
Found the issue where @unknownbrackets did some good research on this in #6483 . Possibly simply discard AA lines when texturing is enabled and the current framebuffer is bound as texture (and a few of the other modes are set right)? |
This game is drawing the lines with:
I guess it must just be the lighting. I'll add some notes about echochrome to the other issue. -[Unknown] |
When I Saw a Tartarus transformation scene in 4/21 dark hour in P3P I saw these Lines In the Emulator but it does not appear in real PSP.
PPSSPP:
Real PSP:
The text was updated successfully, but these errors were encountered: