Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metal Gear Solid - Peace Walker hits the new viewport/scissor assert #12990

Closed
hrydgard opened this issue May 31, 2020 · 1 comment
Closed

Metal Gear Solid - Peace Walker hits the new viewport/scissor assert #12990

hrydgard opened this issue May 31, 2020 · 1 comment
Milestone
v1.10.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented May 31, 2020 •
edited
Loading

Mainly a note to self, will investigate tomorrow. Happens when starting a new game.

Seems there's still some edge case left that my renderpass id check doesn't catch - instead the new viewport/scissor assert finds something.

It's the pass from RebindFramebuffer in FramebufferManagerVulkan::BindFramebufferAsColorTexture. Really not sure why the steps_ counter hasn't changed (that would have dirtied DIRTY_VIEWPORTSCISSOR_STATE).
@hrydgard hrydgard added this to the v1.10.0 milestone May 31, 2020
@ghost ghost mentioned this issue Jun 1, 2020
Closed
@hrydgard
Copy link
Owner Author

hrydgard commented Jun 2, 2020

Fixed by #12993 .

@hrydgard hrydgard closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10.0
Development

No branches or pull requests
1 participant
@hrydgard