Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burnout Dominator rendering errors in Vulkan on PowerVR GE8320 #17044

Closed
hrydgard opened this issue Mar 2, 2023 · 4 comments · Fixed by #17232
Closed

Burnout Dominator rendering errors in Vulkan on PowerVR GE8320 #17044

hrydgard opened this issue Mar 2, 2023 · 4 comments · Fixed by #17232
Labels
GE emulation Backend-independent GPU issues PowerVR GPU
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Mar 2, 2023

image

Car looks kinda broken in Vulkan, it seems, while OpenGL is fine.

@hrydgard hrydgard added PowerVR GPU GE emulation Backend-independent GPU issues labels Mar 2, 2023
@hrydgard hrydgard added this to the v1.15.0 milestone Mar 2, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented Apr 2, 2023

On my Galaxy A21, it's utterly broken, much more than in the screenshot above. However, that's because DisableAccurateDepth is set for this game. If I remove that, then all is well, and it's very playable. Well, I guess it's still unclear why inaccurate depth is so broken here.. but doesn't seem worth digging into.

So then it's mostly a matter of how we change the workings of that compat.ini flag, so it can still fix whatever it was there for before. Gonna have to do some digging for the reason it was flagged, and testing on other devices, then...

@unknownbrackets
Copy link
Collaborator

I thought the inaccurate depth path (designed really for OpenGL) sometimes sent depth ranges as i.e. [1.0, 0.75] and assumes glDepthRangef() will handle this. I think for Vulkan/etc. it tries swapping the values since this isn't supported, which obviously won't actually flip the Z output.

So really I'm not sure why we would use non-accurate depth outside GL...

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Apr 2, 2023

Right. I think this game was added here because of misbehavior on Mali with OpenGL, and the case for just never using inaccurate depth with Vulkan is probably fairly solid..

@hrydgard
Copy link
Owner Author

hrydgard commented Apr 3, 2023

OK so it turns out on most GPU models we already ignored the disableaccurate flag with Vulkan, but not IMGTec/PVR. Fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues PowerVR GPU
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants