Enable [DisallowFramebufferAtOffset] for WWE SvR 2006. #18009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The game renders some audience members into sprites to individual render targets out in the "stride border" of one of the main framebuffers, and then textures from that to actually then place them in the scene.
We would accidentally expand one of the main framebuffers to accomodate for drawing one of the sprites, but not the others. This cause a lot of badness like repeated texturing from the framebuffer being rendered to every other frame, and some other confusion.
Simply enabling this compat flag that I created recently for a somewhat similar situation in LBP (see #16520 ) fixes it. Though, I'm not 100% happy that our other framebuffer management is unable to handle the wacky situation that merging one of the sprites with the main framebuffer caused.
Fixes #13797
Fixes #13822