Android: Add both a lost and restore phase #8968
Conversation
The enum type was not hurting anyone, since the values were the same.
|
#8912 still not fix |
|
I see compile error on log........ 09-11 12:40:52.235: I/NativeApp(28172): gl_lost() restoring 4 items: |
Lost = delete, restore = create. Let's stick to never overlapping. May help hrydgard#8912.
unknownbrackets
force-pushed
the
gl-lost
branch
from
5e9d2df to
98b523e
Compare
|
Sorry - try again. I clearly didn't test enough, because I had a really stupid typo that was causing that. -[Unknown] |
|
Well done,fix #8912 |
|
Can you also remove warning ? |
| @@ -1068,7 +1068,7 @@ void PSPSaveDialog::ExecuteNotVisibleIOAction() { | |||
| { | |||
| bool result = param.GetSize(param.GetPspParam()); | |||
| // TODO: According to JPCSP, should test/verify this part but seems edge casey. | |||
| if (MemoryStick_State() != PSP_MEMORYSTICK_STATE_DRIVER_READY) { | |||
| if (MemoryStick_State() != PSP_MEMORYSTICK_STATE_INSERTED) { | |||
There was a problem hiding this comment.
Sorry, just saw the warning when compiling so snuck it in.
-[Unknown]
|
I think we've tried this kind of thing before with inconclusive results, but since this helps, I'm totally fine with this as it makes sense. |
|
I think that this fix should mention in readme |
|
@sum2012 okay, sure. -[Unknown] |
It seemed like you may have thought of this at one point. Here's my theory on what's happening:
So the goal here is to break those up, and clear/delete things in lost, but recreate on restore. I don't think it really adds much complexity anywhere.
Could help #8912 or #8906.
-[Unknown]