-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression : FMV cutscene stutter and perfomance are worse than older version #9262
Comments
Thanks for reporting, that's quite unexpected.. More specifically, what devices are these? |
Is texture scaling enabled? Maybe it's the same issue as #9125 |
Good thought, could very well be. I plan to look into that one soon. |
@DonelBueno no , they aren't , i'm not prefer to turn on texture upscaling on mobile |
@hrydgard i have both old tablet is using Rockchip ( Mali-400) and Mediatek (PowerVR SGX 544) |
I now believe this is indeed related to #9125 even if no scaling is enabled. Will investigate soon. |
I'm not sure if this has a shared cause - the biggest difference is we'd be checking the alpha on the entire video texture on more frames. I hope that's not enough to lose 30% of performance. Maybe it's the validation of the frame packets? Can you identify which build first had worse performance, and which build most recently was still fine? As narrow a range as possible, from the builds on the buildbot, please. -[Unknown] |
@unknownbrackets i'm mention this above , using version 1.2.1 , FMV FPS and performance are good 100% , switch to 1.3.1 , it's drop FPS |
Which git build specifically started this problem? There are about 1000 changes between v1.2.1 and v1.3. If you tried 8 builds you'd narrow that down to less than 5 changes, which might make the bug easy to find. -[Unknown] |
oh , i don't know because between 1.2.1 to 1.3.1 , i'm busy and don't have to test this build |
ok , i will try to find git build in 1.2.1 version have to this issues |
That's https://github.com/hrydgard/ppsspp/commits/51bcb02 but that can't be the one, got to be a nearby one. |
http://buildbot.orphis.net/ppsspp/index.php?m=fulllist Right before is the merge of the IR interpreter #8725, after is 1f28d80 which does not seem relevant... Pretty odd. |
Just to be sure: you don't have the rewind feature enabled, right? -[Unknown] |
@unknownbrackets nope , i started game normally , no load save state |
Okay, I'm reproducing. It almost seems like ffmpeg may not be using threads now, or something is different about what happens in it. Must be an init problem - was caused by 558b462. It definitely looks like ffmpeg is using threads to decode before, and is not using threads to decode now. Skipping -[Unknown] |
Yeah , i see , i was find out the git build to easy to find problem |
This was previously getting (accidentally?) enabled by the call to `avformat_find_stream_info()`. See hrydgard#9262.
@unknownbrackets test again new build , it's temporary fixed |
temporary? |
I mean it's fixed for me , what about of the others ? |
Well, it's obviously fixed for Unknown as well. I will try it soon also, but I'm closing. Let's reopen if anyone still see slowdowns. |
I have a tablet using Mali and PowerVR , both tablet I'm tested in newer build and it doesn't fixed , perfomance ingame and FMV cutscene are worse than older version , these picture below are same setting config
Game tested : Patapon 3 , Star Ocean , P3P , The 3rd Birthday
In 1.3.0.1 and newer build , is stutter and worse perfomance
In 1.2.2 and older , is better and stable
The text was updated successfully, but these errors were encountered: