Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression : FMV cutscene stutter and perfomance are worse than older version #9262

Closed
zminhquanz opened this issue Jan 31, 2017 · 23 comments
Closed
Milestone

Comments

@zminhquanz
Copy link
Contributor

zminhquanz commented Jan 31, 2017

I have a tablet using Mali and PowerVR , both tablet I'm tested in newer build and it doesn't fixed , perfomance ingame and FMV cutscene are worse than older version , these picture below are same setting config
Game tested : Patapon 3 , Star Ocean , P3P , The 3rd Birthday

In 1.3.0.1 and newer build , is stutter and worse perfomance
2017_1_31_8_15_7_126_pm
2017_1_31_8_17_15_686_pm
2017_1_31_8_18_4_644_pm
2017_1_31_8_19_45_862_pm

In 1.2.2 and older , is better and stable
2017_1_31_8_28_12_67_pm
2017_1_31_8_28_39_533_pm
2017_1_31_8_29_23_155_pm
2017_1_31_8_29_50_723_pm

@hrydgard
Copy link
Owner

hrydgard commented Jan 31, 2017

Thanks for reporting, that's quite unexpected..

More specifically, what devices are these?

@hrydgard hrydgard added this to the v1.4.0 milestone Jan 31, 2017
@DonelBueno
Copy link

Is texture scaling enabled? Maybe it's the same issue as #9125

@hrydgard
Copy link
Owner

Good thought, could very well be. I plan to look into that one soon.

@zminhquanz
Copy link
Contributor Author

zminhquanz commented Jan 31, 2017

@DonelBueno no , they aren't , i'm not prefer to turn on texture upscaling on mobile

@zminhquanz
Copy link
Contributor Author

zminhquanz commented Feb 1, 2017

@hrydgard i have both old tablet is using Rockchip ( Mali-400) and Mediatek (PowerVR SGX 544)

@hrydgard
Copy link
Owner

I now believe this is indeed related to #9125 even if no scaling is enabled. Will investigate soon.

@unknownbrackets
Copy link
Collaborator

I'm not sure if this has a shared cause - the biggest difference is we'd be checking the alpha on the entire video texture on more frames. I hope that's not enough to lose 30% of performance.

Maybe it's the validation of the frame packets? Can you identify which build first had worse performance, and which build most recently was still fine? As narrow a range as possible, from the builds on the buildbot, please.

-[Unknown]

@zminhquanz
Copy link
Contributor Author

@unknownbrackets i'm mention this above , using version 1.2.1 , FMV FPS and performance are good 100% , switch to 1.3.1 , it's drop FPS

@unknownbrackets
Copy link
Collaborator

Which git build specifically started this problem? There are about 1000 changes between v1.2.1 and v1.3. If you tried 8 builds you'd narrow that down to less than 5 changes, which might make the bug easy to find.

-[Unknown]

@zminhquanz
Copy link
Contributor Author

oh , i don't know because between 1.2.1 to 1.3.1 , i'm busy and don't have to test this build

@zminhquanz
Copy link
Contributor Author

ok , i will try to find git build in 1.2.1 version have to this issues

@hrydgard
Copy link
Owner

That's https://github.com/hrydgard/ppsspp/commits/51bcb02 but that can't be the one, got to be a nearby one.

@hrydgard
Copy link
Owner

hrydgard commented Mar 22, 2017

http://buildbot.orphis.net/ppsspp/index.php?m=fulllist

Right before is the merge of the IR interpreter #8725, after is 1f28d80 which does not seem relevant...

Pretty odd.

@zminhquanz
Copy link
Contributor Author

zminhquanz commented Mar 22, 2017

wait a minute , it's start to slowest down on git geac1848 #8867 ( v1.2.2-821-geac1848 )
@hrydgard yeah , exactly , older build than 821 it's better and isn't slow down , so #8725 which does not seem relevant

@zminhquanz
Copy link
Contributor Author

zminhquanz commented Mar 22, 2017

@hrydgard Newer build git than 821 #8867 , it's slow down it's doesn't fixed in #9447

@unknownbrackets
Copy link
Collaborator

Just to be sure: you don't have the rewind feature enabled, right?

-[Unknown]

@zminhquanz
Copy link
Contributor Author

@unknownbrackets nope , i started game normally , no load save state

@unknownbrackets
Copy link
Collaborator

Okay, I'm reproducing. It almost seems like ffmpeg may not be using threads now, or something is different about what happens in it. Must be an init problem - was caused by 558b462.

It definitely looks like ffmpeg is using threads to decode before, and is not using threads to decode now. Skipping SetupStreams() makes it use threads again, so something about avformat_find_stream_info is enabling threads that isn't happening in SetupStreams().

-[Unknown]

@zminhquanz
Copy link
Contributor Author

Yeah , i see , i was find out the git build to easy to find problem

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Mar 23, 2017
This was previously getting (accidentally?) enabled by the call to
`avformat_find_stream_info()`.  See hrydgard#9262.
@zminhquanz
Copy link
Contributor Author

@unknownbrackets test again new build , it's temporary fixed

@hrydgard
Copy link
Owner

temporary?

@zminhquanz
Copy link
Contributor Author

I mean it's fixed for me , what about of the others ?

@hrydgard
Copy link
Owner

Well, it's obviously fixed for Unknown as well. I will try it soon also, but I'm closing. Let's reopen if anyone still see slowdowns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants