Correct provoking vertex for lighting when flat shading #11577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It needs to use the provoking color, regardless of culling or clipping. Fixes Blade Dancer lighting (see hrydgard#4140.)
This might interact strangely with skinning of texture matrix mapping, but they're not likely to be used together.
hrydgard
reviewed
Nov 23, 2018
| @@ -354,6 +351,8 @@ void SoftwareTransform( | |||
|
|
|||
| case GE_TEXMAP_TEXTURE_MATRIX: | |||
| { | |||
| // TODO: What's the correct behavior with flat shading? Provoked normal or real normal? | |||
There was a problem hiding this comment.
My guess would be real normal, flat shading is not really related to the texture pipe at all I think..
|
In the software renderer, I wonder if it wouldn't be more elegant to add a flag to reverse the backface culling, instead of keep the reordering of the verts and adding that argument. But I'm fine with it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Blade Dancer lighting problem in #4140.
I'm not sure when this was fixed for OpenGL, but it turns out that it was already fixed there. This fixes separate bugs in software and hardware rendering that had the same basic results but different causes (realizing that was key to fixing...)
This doesn't solve two areas I have not yet tested, although they're edge cases:
-[Unknown]