Windows: Detect Vulkan in separate process #11802
Merged
+67
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should avoid crashes with broken AMD drivers that can't initialize Vulkan properly. Instead, Vulkan will show up as unavailable. Disabled during debug to allow for debugging.
|
Wow, nice. I'm very sad that this is needed, it really shouldn't be, but this seems like the safest approach until AMD fixes their stuff (and even after, because not everyone will update their drivers..). |
This was referenced Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid crashes with broken AMD drivers that can't initialize Vulkan properly. Instead, Vulkan will show up as unavailable.
Disabled during debug to allow for debugging.
This seems like the best way to work around #11719, since it seems to only happen on Windows.
Important note: Not actually tested on an affected device with AMD drivers. Just simulated a crash by making
pApplicationInfoinvalid.That said, expected to fix #11719 and fix #11679. Probably not #11654, but maybe?
-[Unknown]