Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compat option to use Unknown's accurate dotprod for VMMUL. #12214

Closed
wants to merge 1 commit into from

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 4, 2019

And use it to eliminate the long standing problem of Tekken 6 leg shaking. Fixes #5399.

This is kind of hacky, but it's the first use of our (part mine but mostly @unknownbrackets) recent findings about the accuracy of the VFPU dot product, see #2990.

This simply takes the latest version of vfpu_dot from https://github.com/hrydgard/ppsspp/compare/master...unknownbrackets:vfpu-dot?expand=1 (which will need rebasing) and applies it only to vmmul for now, which is enough to eliminate the leg shaking problem in Tekken 6.

It's really just the start, later we will expand the use of these findings, and if performance can be made good enough we'll enable it for all games (with maybe an opt-out for any game that gets hit unusually hard).

@hrydgard hrydgard added this to the v1.9.0 milestone Aug 4, 2019
@unknownbrackets
Copy link
Collaborator

I think there's value to the commits that chaneg the implementation, implement INF * 0 properly, etc.

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 4, 2019

Yeah true, I agree - I'll split the commit up and include the various versions.

@LunaMoo
Copy link
Collaborator

LunaMoo commented Aug 4, 2019

Here's a more complete compat list of id's:

# Tekken 5 DR
ULJS00048 = true
ULUS10139 = true
UCES00356 = true
ULJS19013 = true
NPJH50137 = true

# Tekken 6
ULUS10466 = true
ULES01376 = true
ULJS00224 = true
NPUH10047 = true
ULAS42214 = true
ULJS19054 = true
NPJH50184 = true

@unknownbrackets
Copy link
Collaborator

Created #12217 with the full history (adding on this commit, essentially, although I missed the gitignore change.)

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Aug 5, 2019

Closing in favor of #12217.

@hrydgard hrydgard closed this Aug 5, 2019
@unknownbrackets unknownbrackets deleted the tekken-leg-shake-workaround branch August 5, 2019 23:14
@unknownbrackets unknownbrackets removed this from the v1.9.0 milestone Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tekken 6 (ULUS10466): Fighters' legs tremble/shudder/"flicker" in battle
3 participants