Fix Pangya(KS).

[shenweip]

Pangya(KS) seems want to check something base on a delay(over 15ms) and system time.Anyhow, the game work now.

Also fix #12492 ,the issue occur since commit e09296b,re-grab SCE_KERNEL_ERROR_NOCWD now.

[hrydgard]

Hm, the delay is fine, maybe even don't need the REALISTIC check, but the NOCWD thing... needs thinking about.

Were you able to determine which in particular of the many "|| error == SCE_KERNEL_ERROR_NOCWD" changes that fixed it? Because I think that in many or most of the cases, it's not correct to ignore the error. Some hardware testing may be needed here.

[hrydgard]

Cool, that puts a little more light on what might be going on here. @unknownbrackets it seems that a NOCWD error can linger around and prevent a successful open? Or something like that? I don't have time right now to dig deep but will look again in the weekend.

[shenweip]

Yeah, I think i misunderstand someting before.@hrydgard The game actually need a SCE_KERNEL_ERROR_NOCWD to return to sceIoOpen if the file not found.But SCE_KERNEL_ERROR_NOCWD was missed since commit e09296b and overwritten by ERROR_ERRNO_FILE_NOT_FOUND because file path mapping is successful.

[unknownbrackets]

Hmm, if anything I'd prefer returning -SCE_KERNEL_ERROR_NOCWD to get a positive value, and then just return -error if error != 0 and error > 0. Though, I think ignoring that error in some calls is just papering over other bugs.

-[Unknown]

[shenweip]

Though, I think ignoring that error in some calls is just papering over other bugs.

@unknownbrackets Do you mean not ignoring the positive value from MapFilePath() would be better?It seems to be likely to break somethings though.

[unknownbrackets]

I mean that SCE_KERNEL_ERROR_NOCWD should probably be returned by all calls as an error, not just sceIoOpen. That is, it should just be return SCE_KERNEL_ERROR_NOCWD; not return 1;.

If that breaks anything, in theory it just means we've got an issue with cwd management. IIRC doing that before broke Final Fantasy 3 or something, but decent chance we've fixed that bug by now...

-[Unknown]

[shenweip]

Alright,thanks @unknownbrackets ,done now.

[hrydgard]

Cool, looks good.