Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vsync in all hardware backends, support runtime update #12659

Merged
merged 4 commits into from
Mar 1, 2020

Conversation

unknownbrackets
Copy link
Collaborator

This does a few things:

-[Unknown]

We already do unthrottle checking here.
This allows the setting to be changed at runtime in Vulkan too.

Should help hrydgard#10105.
@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Mar 1, 2020
@hrydgard
Copy link
Owner

hrydgard commented Mar 1, 2020

Looks good!

@hrydgard hrydgard merged commit 2ec8295 into hrydgard:master Mar 1, 2020
@unknownbrackets unknownbrackets deleted the vsync branch March 1, 2020 14:17
@ghost
Copy link

ghost commented Mar 4, 2020

Finally no micro stuttering anymore.

@unknownbrackets
Copy link
Collaborator Author

Probably, the affect on OpenGL was because I moved the vsync interval setting to BeginHostFrame, where it should've been. That just means the driver didn't like when we were updating the value, I guess.

That's not relevant to the other backends, though, because their APIs are different.

-[Unknown]

@ghost
Copy link

ghost commented Mar 4, 2020

Also , Vsync on DX9 no longer disables the "unthrottle" button from working.
Previously it was always stuck on 60 fps even if you tried to unthrottle.
Dunno if it fixes any issue here but just pointing out.

@unknownbrackets
Copy link
Collaborator Author

That's what "Skips vsync for all other backends when unthrottled (like OpenGL.) Fixes #7929." meant.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dx11 vsync not implemented D3D vsync prevents unthrottle from working right (plus, fixed hotkey bug)
2 participants