SDL: Try to continue if EGL init fails #12957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably we should just stop using EGL on SDL2, but I'm not sure if that's making things work for some users. But if EGL init fails, try to avoid a segfault and skip EGL. Should help hrydgard#12474.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL2 inits EGL for us, and does some heuristics to get color sizes as close to what we request as possible. It doesn't care about GL version or alpha, even on Mali.
Probably we should just stop using EGL on SDL2, but I'm not sure if that's making things work for some users. But if EGL init fails, try to avoid a segfault and skip EGL. It can't be worse than segfaulting.
Should help #12474, but untested.
-[Unknown]