Vulkan: Make sure textures/samplers are unbound at the end of PresentationCommon::CopyToOutput #13138
+48
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationCommon::CopyToOutput. Validation caught an issue where old stuff lingered in sampler 1 and texture 1. Bug probably introduced in #12921, but could also be others.
|
Gonna merge this prematurely since it's kinda critical and I'm doing stuff on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation caught an issue (and I had a crash in a Debug build, too) where old stuff lingered in sampler 1 and texture 1.
Bug probably introduced in #12921, but could also be others.
This could maybe be done more elegantly in some other way, like unbinding stuff when we bind a new pipeline that uses less samplers, or something like that. But we don't have a clear view how many samplers a pipeline uses here.
Also started doing some similar cleanup in the other backends but likely not necessary.