Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp sceKernelFindModuleByName #13387

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Sep 5, 2020

#13204
Is it wrong so that don't do before ?

@hrydgard
Copy link
Owner

hrydgard commented Sep 6, 2020

I don't quite understand why we need to add one?

@hrydgard hrydgard added the HLE/Kernel Kernel, memory manager, other HLE issues label Sep 6, 2020
@hrydgard hrydgard added this to the v1.11.0 milestone Sep 6, 2020
@unknownbrackets
Copy link
Collaborator

Typically, any kernel code calling these funcs is trying to patch kernel code - kernel code that doesn't exist in PPSSPP. This is generally a function unlikely to ever really work under HLE.

That said, it could also be used to patch game code, I suppose, which might work. But we'd want to create a test of what it's doing so we handle modules properly full the full thing. I'm not sure this would work in that case as-is.

-[Unknown]

@sum2012
Copy link
Collaborator Author

sum2012 commented Sep 6, 2020

@hrydgard
https://github.com/hrydgard/ppsspp/blob/master/Core/HLE/HLE.cpp#L170
GetModuleIndex return -1 ,0,1,etc
so that sceKernelFindModuleByName return should be 0,1,2,etc
It mean GetModuleIndex + 1

@unknownbrackets jpcsp 's code work 99.9% with patched game except #13204

The game still not work,leave this is okay.

@hrydgard
Copy link
Owner

hrydgard commented Sep 8, 2020

Oh so it's so that there's space for negative error codes, I see, although that's a rather odd interface if so. Anyway, I'll merge it...

@hrydgard hrydgard merged commit 1052047 into hrydgard:master Sep 8, 2020
@sum2012 sum2012 deleted the kernel_minor branch September 27, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HLE/Kernel Kernel, memory manager, other HLE issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants