Refactor software renderer jit cache to be shared #15180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to compile different entries or push regs.
Dealing with types was annoying, and this helps validate the right register is released.
Intentionally just the name changes in this commit.
This makes it easier to use vectors elsewhere.
This makes it match SSE and easier to keep things generic. Will impact alignment of non-packed Vec2/Vec3.
unknownbrackets
force-pushed
the
softjit-args
branch
from
5bde13d to
2d8fdd8
Compare
|
Apparently on MSVC ARM64, float32x4_t and int32x4_t are the same type. Annoying. -[Unknown] |
Oops, this is of course not put on the stack, it's in R8.
hrydgard
approved these changes
Nov 28, 2021
|
Not the easiest thing to review, but it looks good! Let's get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the huge #15163 pull, this should be more reasonably sized.
Basically, this changes the handling of the register cache (not memory backed, just a cache in registers) used for the draw pixel jit:
Relatedly, it prepares the argument types used to keep args vector for DrawPixel so they can be used elsewhere. Found ways to move away from preprocessor defines, mostly, too.
Lastly, this also changes ARM64 so that Math3D Vec2/Vec3/Vec4 are unioned with SIMD. Mainly, this is to allow passing directly as a vector argument in functions. It will impact memory requirements of Vec2/Vec3.
Most of the lines changed are renames. I kept just renames in 3d5bced, so look at the other commits for actual behavior changes.
-[Unknown]