Vulkan: Don't use multithreaded rendering if buffer commands (frames in flight) is set to 1 #17831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 1 It has no benefit, and loses by a few percent in simple benchmarking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's turn it off in this particular case, as it then has no benefit (no overlapping processing), and loses by a few percent in simple benchmarking.
We'll still keep the dev option to turn off multithreading for other cases if desired, but there's not much point in exposing it more, I think - this is the one case where it's a positive.
A little bit hard to centralize the logic since it's kinda spread out between the context and render manager.
Will make it cleaner at a later point, there's some refactoring I want to do in this area.