Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets/lang: Update zh_CN.ini #18193

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Croden1999
Copy link
Contributor

No description provided.

@hrydgard
Copy link
Owner

This is a big change, I'll wait until the 1.16 release process is done, and also for some more feedback.

@sum2012 ? @Narugakuruga ?

@hrydgard hrydgard added this to the v1.17.0 milestone Sep 22, 2023
@hrydgard hrydgard added the Translation Translation-related issues label Sep 22, 2023
@Croden1999
Copy link
Contributor Author

This is a big change, I'll wait until the 1.16 release process is done, and also for some more feedback.

@sum2012 ? @Narugakuruga ?

Some punctuation fixes, and updated translations, Mr. Hrydgard.

@Narugakuruga
Copy link
Contributor

Narugakuruga commented Sep 22, 2023

image
Personally I would say the interval for blanket is too wide, you would less likely to associate the setting with what's in the blanket.

image

the space for English word is to distinguish Hanzi and Alphabet word, I think keep them as they were is okay. (But yeah it need some unification I think)

image
These ellipsis are too long for UIs. You usually use 6 dots ellipsis to stress some emotion. It is not necessary for UI.

In general punctuation is sometimes trivial.
If it looks neat and tidy, it works.
Therefore strings need to be tested and Iterated in actual UI, then the change is more convincing.

@Narugakuruga
Copy link
Contributor

Narugakuruga commented Sep 22, 2023

  1. The translation fixes are nice.

  2. ellipsis and blanket are a bit off in actual display.

  3. Deleting Space for English word can be optimized more. Don't have to delete every space. That's the tricky one. (for unfamiliar words, usually, add space for more clearness, or it will be a mess)

Imagine an example:
Iuseppsspponxiamishoujianditsfun → Iuseppssppon xiamishouji anditsfun

@Croden1999
Copy link
Contributor Author

Croden1999 commented Sep 22, 2023

  1. The translation fixes are nice.
  2. ellipsis and blanket are a bit off in actual display.
  3. Deleting Space for English word can be optimized more. Don't have to delete every space. That's the tricky one. (for unfamiliar words, usually, add space for more clearness, or it will be a mess)

Imagine an example: Iuseppsspponxiamishoujianditsfun → Iuseppssppon xiamishouji anditsfun

but here is for Chinese punctuation and format are need fix and corrent, not other lang, is uniform format here
also you can view my lang contributions in other repos

e.g.,

hrydgard added a commit that referenced this pull request Sep 22, 2023
@Narugakuruga
Copy link
Contributor

I think there's no "correct" in punctuation.
In tencent's QQ they use the same English blanket for UI.
And it looks tidy too.
IMG_20230922_220245

@hrydgard
Copy link
Owner

I took the new WAV format string and merged only that for now, until you guys have figured out how things should be :)

@Narugakuruga
Copy link
Contributor

Narugakuruga commented Sep 22, 2023

Okay,
Here's another example show 3 dots used in China's Uber (滴滴打车)
IMG_20230922_225547

@Croden1999
Copy link
Contributor Author

Okay, Here's another example show 3 dots used in China's Uber (滴滴打车) IMG_20230922_225547

不一定非要跟着其他应用走,这是在PPSSPP中的显示,也参考了PSP和PSVita上的语言

@hrydgard
Copy link
Owner

hrydgard commented Sep 22, 2023

Just noting that when you guys agree, I'm happy to merge this. Let me know by posting here - I'll wait for a bit longer first though to see if @sum2012 has any additional feedback.

@sum2012
Copy link
Collaborator

sum2012 commented Sep 22, 2023

I have no additional feedback.

@Narugakuruga
Copy link
Contributor

Look good to me

@hrydgard hrydgard merged commit dea038a into hrydgard:master Sep 29, 2023
4 checks passed
@Croden1999 Croden1999 deleted the Croden1999-patch-lang branch December 13, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants