Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR - Gran Turismo camera shaking workaround #18536

Closed
wants to merge 1 commit into from
Closed

OpenXR - Gran Turismo camera shaking workaround #18536

wants to merge 1 commit into from

Conversation

lvonasek
Copy link
Contributor

Since #18438 there is VR camera shaking in Gran Turismo. This PR fixes that on all headsets.

@hrydgard
Copy link
Owner

hrydgard commented Dec 12, 2023

The shaking thing in GT is a type of temporal antialiasing using the slowness of the PSP's LCD. It of course works very badly at higher screen resolutions.

It can actually be turned-off in-game with a setting: External video output.

So having a code workaround for it feels a bit excessive - though, I guess it's also awkward to have to tell the player to use this option, and we currently don't have a good way to do it..

@lvonasek
Copy link
Contributor Author

Interesting. I wouldn't expect the shaking is an intention. I leave it on you but I find pity that the best looking PSP game don't work out of the box (even that it worked in the previous version). The new compat flag is basically switching between an old projection matrix Hack and new projection matrix hack.

@hrydgard
Copy link
Owner

How did it work in VR previously?

@lvonasek
Copy link
Contributor Author

lvonasek commented Dec 12, 2023

It used the projection matrix from OpenXR and changed the signs of all 16 values to match the signs of the game projection matrix. That for some reason is very broken on Quest3.

@lvonasek
Copy link
Contributor Author

I am closing this. Let's keep the VR integration simple.

@lvonasek lvonasek closed this Dec 15, 2023
@lvonasek lvonasek deleted the compat-gran-turismo branch December 15, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants