getLocalIp: Keep looking if we see 127.0.0.1 #19926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As i remembered on Linux the first LAN IP found doesn't always have internet connection if you have multiple network interfaces, and can be inconsistent. So the best approach to find the network that have internet access is by trying to send/connect to a public IP as reference (from what i found at stackoverflow we can even connect using UDP for this), which will then have a valid IP that have internet access bound on the socket, which can be retrieved using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This path is unix-only, so it accounts for the difference against Windows seen in #19919
Fixes #19919
Turns out that it seems to often just find 127.0.0.1, but if you let it keep looking it this case, it'll find the appropriate address to use, fixing the problem.
Not sure whether it's worth using this path or if we should use the next fallback instead as used by Windows, where we connect to 8.8.8.8 and check the local IP on the connection.