Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons/texts missing when mipmap ON in Tactic Ogre #2844

Merged
merged 2 commits into from
Jul 19, 2013
Merged

Fix buttons/texts missing when mipmap ON in Tactic Ogre #2844

merged 2 commits into from
Jul 19, 2013

Conversation

dbz400
Copy link
Contributor

@dbz400 dbz400 commented Jul 19, 2013

Issue #2286

@solarmystic
Copy link
Contributor

@raven02

Would this also fix other games with Mipmapping issues? Does it need to be tested?

@dbz400
Copy link
Contributor Author

dbz400 commented Jul 19, 2013

May be .However i don't have any other games that have mipmapping issue so far .

@solarmystic
Copy link
Contributor

If this helps out, I will be able to close #2286

@solarmystic
Copy link
Contributor

Also @raven02, are you sure this won't break your other game that needs Mipmapping to be ON like this one? :-

eaede89#commitcomment-3474733

eaede89#commitcomment-3474980

There was a reason why @hrydgard reverted the commit you're about to enable again (he commented it out with // as you can see in the code), you better test out that game first.

(I don't know what the title is, I don't recognise the Chinese/Japanese characters in your screenshot)

magFilt &= ~1;
minFilt &= ~1;
}

if (!g_Config.bMipMap) {
if (!g_Config.bMipMap || noMip || !noMip) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x || !x = true

so this will always happen, which also means that mipmapping is now always turned off. I don't think that should be necessary (Although I really don't understand what the real problem is here, it's really weird).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach would be better ?

bool noMip = (gstate.texlevel & 0xFFFFFF) == 0x000001 || (gstate.texlevel & 0xFFFFFF) == 0x100001 ;  // Fix texlevel at 0

// Mipmapping OFF 
if (!g_Config.bMipMap || noMip ) {
    magFilt &= 1;
    minFilt &= 1;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine if it solves it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Already tested , it is working well .

@dbz400
Copy link
Contributor Author

dbz400 commented Jul 19, 2013

I think one of the reason @hrydgard revert that commit because it only partially working at that time . As @unknownbrackets , button did work somehow but not texts . Right now both should be rendered correctly when mipmap ON.

Regarding another game that need mipmap ON , i think it is another issues

  1. It works on windows only but not on Android
  2. It works ok when read FBO to memory ON which is similar issue to 3rd birthday

hrydgard added a commit that referenced this pull request Jul 19, 2013
Fix buttons/texts missing when mipmap ON in Tactic Ogre
@hrydgard hrydgard merged commit 88685b0 into hrydgard:master Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants