Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete framebuffers on format change #3662

Merged
merged 2 commits into from
Sep 6, 2013

Conversation

unknownbrackets
Copy link
Collaborator

This fixes #2758 and seems likely to fix other games mentioned there too.

The only dangerous thing is it might churn if the game uses the same memory as two types of framebuffers over and over.

-[Unknown]

@unknownbrackets
Copy link
Collaborator Author

As mentioned in the issue, I thought of another method, might be good in addition / if this causes problems. Could scan fbCache_ in DetachFramebuffer(). That's probably why this change helps.

But I'm not sure there's a reason to maintain the wrong format fb anyway?

-[Unknown]

@unknownbrackets
Copy link
Collaborator Author

I guess deleting doesn't work for all games, for some reason, but it should be dangerous to keep the old framebuffer's size.

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Sep 6, 2013

There might actually be reasons to retain it, but only if scissor rect or something is set so that they don't actually overlap I guess. would still be kinda strange.

hrydgard added a commit that referenced this pull request Sep 6, 2013
Delete framebuffers on format change
@hrydgard hrydgard merged commit aecc95e into hrydgard:master Sep 6, 2013
@Blutgang
Copy link

Blutgang commented Sep 7, 2013

This pull request seems to break Dissidia 012 Duodecim Final Fantasy and Kingdom Hearts Birth By Sleep FM in Non-buffered rendering mode. (Black screen during battle as well as black cutscenes...the subtitles still show though)

@unknownbrackets
Copy link
Collaborator Author

See #3664.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tactics Ogre: Multiple Graphical Issues
3 participants