Buildfixes + Travis caching #8735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've removed on Windows too, and this fixes a build error.
unknownbrackets
force-pushed
the
ir-jit-test
branch
from
08d2d69 to
e2aca38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler names are a hack that makes it cache per-environment, which many people are currently using. Otherwise, they trash each others caches due to race conditions.
Actually, the cache is currently only working for Linux / gcc / cmake and Linux / gcc / qt. I really want to get it working mainly for Android, but I don't know why it isn't working... maybe we can override the CC or there's more NDK env vars to set.
Anyway, this makes the build clean so we can merge.
-[Unknown]