refactor: don't copy popped frames (#67)

hrzlgnm · Aug 28, 2023 · 12235d4 · 12235d4
1 parent 4ddfe3b
commit 12235d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/vm/vm.cpp b/source/vm/vm.cpp
@@ -383,10 +383,10 @@ auto vm::push_frame(frame&& frm) -> void
     m_frame_index++;
 }
 
-auto vm::pop_frame() -> frame
+auto vm::pop_frame() -> frame&
 {
     m_frame_index--;
-    return m_frames[m_frame_index];
+    return m_frames.at(m_frame_index);
 }
 
 auto vm::push_closure(uint16_t const_idx, uint8_t num_free) -> void

diff --git a/source/vm/vm.hpp b/source/vm/vm.hpp
@@ -57,7 +57,7 @@ struct vm
 
     auto current_frame() -> frame&;
     auto push_frame(frame&& frm) -> void;
-    auto pop_frame() -> frame;
+    auto pop_frame() -> frame&;
     auto push_closure(uint16_t const_idx, uint8_t num_free) -> void;
 
     constants_ptr m_constans;