Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove openai branding, update gym terminology with gymnasium #649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Nov 30, 2024

follow up of #467
address #453

cc @cameronangliss

no logic change whatsoever, just renaming.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (f458350) to head (1cef425).
Report is 103 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   83.38%   85.39%   +2.01%     
==========================================
  Files          39       42       +3     
  Lines        3918     4417     +499     
==========================================
+ Hits         3267     3772     +505     
+ Misses        651      645       -6     

@cameronangliss
Copy link
Contributor

Good call @acxz, this looks good to me at a glance. There seems to be something wrong with the CI (not due to your changes, it seems to be in other PRs too) so we should wait until that is fixed first.

@hsahovic
Copy link
Owner

Thanks @acxz - this looks good

@hsahovic
Copy link
Owner

hsahovic commented Dec 15, 2024

@acxz Unfortunately it looks like your PR conflicts which changes that I just merged - i didn't realize it was the case. Can you rebase and fix the conflict?
I can also fork your branch and do it if you prefer.

@acxz
Copy link
Contributor Author

acxz commented Dec 21, 2024

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants