bug: Automatic column naming #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: * ``get_scores_from_ratings()`` When input a ``pd.Series``, the name of the output series will now become ``ratings.name`` prefixed with "rtg_score". When input a ``pd.DataFrame``, the column names of the out frame will now become ``ratings.columns`` prefixed with "rtg_score_". * ``get_warf_from_ratings()`` When input a ``pd.Series``, the name of the output series will now become ``ratings.name`` prefixed with "warf". When input a ``pd.DataFrame``, the column names of the out frame will now become ``ratings.columns`` prefixed with "warf_". Closes #9
deepakparashar1987
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform review and test code base:
pytestget_scores_from_ratings()When input a
pd.Series, the name of the output series will now becomeratings.nameprefixed with "rtg_score_".When input a
pd.DataFrame, the column names of the output frame will now becomeratings.columnsprefixed with "rtg_score_".The last column name is an example from the "Getting started..." section of the documentation, where the
worst_rtgcolumn has been used as an input parameter.get_warf_from_ratings()When input a
pd.Series, the name of the output series will now becomeratings.nameprefixed with "warf_".When input a
pd.DataFrame, the column names of the output frame will now becomeratings.columnsprefixed with "warf_".The last column name is an example from the "Getting started..." section of the documentation, where the
worst_rtgcolumn has been used as an input parameter.Closes #9